-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Python classes for XSpec convolution models #68
Labels
Comments
I've updated the gist at https://gist.github.com/DougBurke/65dd0716afc061a03d63 to add |
I wonder if there's overlap with #43 - at least in the sense that the output grid may not be the same as the grid we want to evaluate the data on. |
DougBurke
added a commit
to DougBurke/sherpa
that referenced
this issue
Apr 5, 2020
This is waiting on a resoltuion to sherpa#68 before Python classes can be added to use this convolution model.
15 tasks
DougBurke
added a commit
to DougBurke/sherpa
that referenced
this issue
Apr 14, 2020
This is waiting on a resoltuion to sherpa#68 before Python classes can be added to use this convolution model.
DougBurke
added a commit
to DougBurke/sherpa
that referenced
this issue
Jul 21, 2020
This is waiting on a resoltuion to sherpa#68 before Python classes can be added to use this convolution model.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The XSpec models come in additive, multiplicative, convolution, pileup, and mixing-model types. Sherpa already supports additive and multiplicative. It does not support the one pileup model provided by XSpec, but does have its own version of this functionality. This leaves convolution and mixing-model types. This request is about the convolution models only, which are documented at http://heasarc.gsfc.nasa.gov/docs/xanadu/xspec/manual/Convolution.html
The
_xspec.cc
file already contains interfaces to the XSpec convolution models. To support there use in Sherpa we need Python classes.I have an initial set of classes in my branch at https://github.com/DougBurke/sherpa/tree/feature/xspec-convolution-models - which is based on the support I wrote for these models in the CIAO contributed-script package. It is not ready for a PR, as I want to experiment a bit more.
Note that to properly use these models from Sherpa will require a rethink of how model evaluation is done (I will write up thoughts on this in another issue at some point in the near future). That is, some XSpec convolution models can be used as is, but some aren't going to be useful until further changes are made in Sherpa itself.
The gist at https://gist.github.com/DougBurke/65dd0716afc061a03d63 contains the output of a script (and the script itself) that shows the
cflux
andcpflux
models being used - see http://heasarc.gsfc.nasa.gov/docs/xanadu/xspec/manual/XSmodelCflux.html and http://heasarc.gsfc.nasa.gov/docs/xanadu/xspec/manual/XSmodelCpflux.html using DougBurke@ccd2ccfThe text was updated successfully, but these errors were encountered: