Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change invoice for accept numeric type. #110

Merged
merged 1 commit into from
Oct 13, 2021
Merged

Change invoice for accept numeric type. #110

merged 1 commit into from
Oct 13, 2021

Conversation

hooman-mirghasemi
Copy link
Contributor

@hooman-mirghasemi hooman-mirghasemi commented Oct 13, 2021

Now invoice accept amount as integer or float

Description

Describe your changes in detail.

Motivation and context

Why is this change required? What problem does it solve?

If it fixes an open issue, please link to the issue here (if you write fixes #num
or closes #num, the issue will be automatically closed when the pull is accepted.)

How has this been tested?

Please describe in detail how you tested your changes.

Include details of your testing environment, and the tests you ran to
see how your change affects other areas of the code, etc.

Screenshots (if appropriate)

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

Please, please, please, don't send your pull request until all of the boxes are ticked. Once your pull request is created, it will trigger a build on our continuous integration server to make sure your tests and code style pass.

  • I have read the CONTRIBUTING document.
  • My pull request addresses exactly one patch/feature.
  • I have created a branch for this patch/feature.
  • Each individual commit in the pull request is meaningful.
  • I have added tests to cover my changes.
  • If my change requires a change to the documentation, I have updated it accordingly.

If you're unsure about any of these, don't hesitate to ask. We're here to help!

Now invoice accept amount as integer or float
@khanzadimahdi
Copy link
Member

These changes will affect multipay/payment too. could you fix it too?

@khanzadimahdi khanzadimahdi merged commit 73abaea into shetabit:master Oct 13, 2021
@khanzadimahdi
Copy link
Member

I merged this one, please install from master and check if any side effect exists or not.

I will write some tests for such things soon.

@hooman-mirghasemi
Copy link
Contributor Author

I have already made this change in my project by inheriting from the class Invoice.
And I used "yek-pay" gateway for euro currency payment I didn't see any problem.

But since I did not use this repository for the Iranian banks, I can not say for sure that there is no problem and it is very good that you want to write a test for it.

Thank you

@khanzadimahdi
Copy link
Member

If you use any international gateway (Paypal, skrill, etc.) please add them in the package too.

@khanzadimahdi
Copy link
Member

I will release a new version after making sure there are no side effects. thanks for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants