Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change toJson method #48

Merged
merged 2 commits into from
Jan 28, 2021
Merged

Change toJson method #48

merged 2 commits into from
Jan 28, 2021

Conversation

parsagholipour
Copy link
Contributor

Change toJson method to return response with correct http header.

@parsagholipour
Change toJson method
81e1bef 
Return json response in toJson method so we can return it in controllers
@parsagholipour parsagholipour mentioned this pull request Jan 28, 2021
Closed
@khanzadimahdi
Copy link
Member

this package is a pure PHP package and illuminate dependencies must be removed in the next version as a bug-fix.
as you see, there are not any illuminate dependencies in the composer.json file.

thanks for your contribution.

@khanzadimahdi khanzadimahdi merged commit bf83415 into shetabit:master Jan 28, 2021
@parsagholipour parsagholipour mentioned this pull request Jan 29, 2021
Closed
@erfantkerfan erfantkerfan mentioned this pull request May 4, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@parsagholipour @khanzadimahdi