Improve payne hanek #210
Merged
Improve payne hanek #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fpetrogalli
requested changes
Aug 15, 2018
src/libm-tester/tester2simddp.c
Outdated
| #define CONFIG 1 | ||
| #include "helperpurec.h" | ||
| #include "norename.h" | ||
| #ifdef ENABLE_AVX512FNOFMA |
There was a problem hiding this comment.
The changes in this file seem to be unnecessary. If I understand correctly, these are the "nofma" and "pure_c*_scalar" target that are needed for the "determinism" patch, and are unrelated to the improvements of the payne hanek algorithm.
In fact, "rename*nofma.h" is not included in this patch.
May I ask you to revert the changes in this file?
fpetrogalli
requested changes
Aug 15, 2018
src/libm-tester/tester2simddp.c
Outdated
| @@ -126,6 +112,18 @@ typedef Sleef_vector_double_2 vdouble2; | |||
| typedef Sleef_vector_float_2 vfloat2; | |||
| #endif | |||
|
|
|||
| #ifdef ENABLE_VECEXT | |||
There was a problem hiding this comment.
Please revert the change in line 115-126.
| @@ -111,11 +99,9 @@ typedef Sleef_float32x4_t_2 vfloat2; | |||
| #ifdef ENABLE_SVE | |||
| #define CONFIG 1 | |||
| #include "helpersve.h" | |||
| #ifdef DORENAME | |||
There was a problem hiding this comment.
Because DORENAME is always defined.
src/libm-tester/tester2simdsp.c
Outdated
| @@ -127,6 +121,12 @@ typedef Sleef_vector_double_2 vdouble2; | |||
| typedef Sleef_vector_float_2 vfloat2; | |||
| #endif | |||
|
|
|||
| #ifdef ENABLE_PUREC | |||
There was a problem hiding this comment.
Please restore line 124-129 in the original position.
src/libm/sleefsimdsp.c
Outdated
| @@ -2473,6 +2463,7 @@ EXPORT CONST vfloat __tgammaf_u1_finite(vfloat) __attribute__((weak, ali | |||
| // gcc -DENABLE_MAIN -Wno-attributes -I../common -I../arch -DENABLE_AVX2 -mavx2 -mfma sleefsimdsp.c ../common/common.c -lm | |||
| #include <stdio.h> | |||
| #include <stdlib.h> | |||
| #include <math.h> | |||
fpetrogalli
approved these changes
Aug 15, 2018
shibatch
added a commit
that referenced
this pull request
Aug 19, 2018
This patch improves the Payne-Hanek reduction algorithm. The restriction on the input domain of trig functions is all removed.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch improves the Payne-Hanek reduction algorithm.
The restriction on the input domain of trig functions is all removed.