Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve payne hanek #210

Merged
merged 7 commits into from Aug 16, 2018
Merged

Improve payne hanek #210

merged 7 commits into from Aug 16, 2018

Conversation

@shibatch
Copy link
Owner

@shibatch shibatch commented Aug 15, 2018

This patch improves the Payne-Hanek reduction algorithm.
The restriction on the input domain of trig functions is all removed.

shibatch added 5 commits Aug 15, 2018
@shibatch shibatch requested a review from fpetrogalli Aug 15, 2018
#define CONFIG 1
#include "helperpurec.h"
#include "norename.h"
#ifdef ENABLE_AVX512FNOFMA

This comment has been minimized.

@fpetrogalli

fpetrogalli Aug 15, 2018
Collaborator

The changes in this file seem to be unnecessary. If I understand correctly, these are the "nofma" and "pure_c*_scalar" target that are needed for the "determinism" patch, and are unrelated to the improvements of the payne hanek algorithm.

In fact, "rename*nofma.h" is not included in this patch.

May I ask you to revert the changes in this file?

@@ -126,6 +112,18 @@ typedef Sleef_vector_double_2 vdouble2;
typedef Sleef_vector_float_2 vfloat2;
#endif

#ifdef ENABLE_VECEXT

This comment has been minimized.

@fpetrogalli

fpetrogalli Aug 15, 2018
Collaborator

Please revert the change in line 115-126.

@@ -111,11 +99,9 @@ typedef Sleef_float32x4_t_2 vfloat2;
#ifdef ENABLE_SVE
#define CONFIG 1
#include "helpersve.h"
#ifdef DORENAME

This comment has been minimized.

@fpetrogalli

fpetrogalli Aug 15, 2018
Collaborator

Why remove this?

This comment has been minimized.

@shibatch

shibatch Aug 15, 2018
Author Owner

Because DORENAME is always defined.

@@ -127,6 +121,12 @@ typedef Sleef_vector_double_2 vdouble2;
typedef Sleef_vector_float_2 vfloat2;
#endif

#ifdef ENABLE_PUREC

This comment has been minimized.

@fpetrogalli

fpetrogalli Aug 15, 2018
Collaborator

Please restore line 124-129 in the original position.

@@ -2473,6 +2463,7 @@ EXPORT CONST vfloat __tgammaf_u1_finite(vfloat) __attribute__((weak, ali
// gcc -DENABLE_MAIN -Wno-attributes -I../common -I../arch -DENABLE_AVX2 -mavx2 -mfma sleefsimdsp.c ../common/common.c -lm
#include <stdio.h>
#include <stdlib.h>
#include <math.h>

This comment has been minimized.

@fpetrogalli

fpetrogalli Aug 15, 2018
Collaborator

Spurious include?

@shibatch shibatch merged commit 86d5c2d into master Aug 16, 2018
6 checks passed
6 checks passed
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/jenkins/branch This commit looks good
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@shibatch shibatch deleted the Improve_Payne_Hanek branch Aug 16, 2018
shibatch added a commit that referenced this pull request Aug 19, 2018
This patch improves the Payne-Hanek reduction algorithm.
The restriction on the input domain of trig functions is all removed.
@shibatch shibatch mentioned this pull request Aug 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.