Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation under Windows with MinGW #266

Merged
merged 2 commits into from Jul 30, 2019

Conversation

@nxrighthere
Copy link
Contributor

commented Jul 26, 2019

The compiler-specific condition for type and cat is incorrect. Also <io.h> is missed for _get_osfhandle.

@nxrighthere

This comment has been minimized.

Copy link
Contributor Author

commented Jul 26, 2019

What's wrong with the Jenkins? The first commit with WIN32 didn't pass the build, the second is pending for almost 5 hours.

@shibatch

This comment has been minimized.

Copy link
Owner

commented Jul 27, 2019

@nxrighthere Thank you for your commit!
I am sorry, but Jenkins is not working properly now, due to expiration of emulator.
I will fix it soon.

@shibatch shibatch merged commit 7f523de into shibatch:master Jul 30, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.