Update to handle in-memory filelike objects #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SpangleLabs
reviewed
Oct 12, 2020
setup.py
Outdated
| @@ -23,6 +23,7 @@ | |||
| py_modules=['imagesize'], | |||
| test_suite='test', | |||
| python_requires=">=2.7, !=3.0.*, !=3.1.*, !=3.2.*, !=3.3.*", | |||
| install_requires=['requests',], | |||
There was a problem hiding this comment.
We only need requests for tests, right? So that should probably be in tests_require rather than install_requires
There was a problem hiding this comment.
I switched to urllib.request and got rid of requests altogether. Also, hasattr(filepath, "read") is changed to isinstance(filepath, io.BytesIO) for better checking of a file-like object in 2756936
There was a problem hiding this comment.
Ah, yes, that's probably a good change. Something supporting read() might not also support seek() and such, after all. Though the idea of duck-typing it is nice
…) in imagesize.py, requests.get to urllib.request.urlopen in test/test_get_filelike.py [requsets package no longer needed]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle in-memory file-like objects
tests added: