Repair #4
Merged
Repair #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… failed (apache#1156) * fix apache#1153 Put task back into queue if task onExecuting failed --------- Co-authored-by: luting <dylzlt93299@gmail.com>
remove unused imports
…mit failed (apache#1104) * improve apache#1103 clear the optimizing tasks when the optimizing commit failed * improve apache#1103 clear the optimizing tasks when the optimizing commit failed * fix code review * fix CI * fix code review * clear failed tasks * add clear failed tasks log * fix code review * fix check style * fix code review --------- Co-authored-by: luting <dylzlt93299@gmail.com>
…eSpillableMap (apache#1048) * improve apache#1009 modify spill map config in optimize group * improve apache#1009 improve properties names * fix apache#1047 1.modify the logic of estimating size in the SimpleSpillableMap 2.unified the units in optimizer group config * fix unit test * use Generics for StructLikeMap * fix code review * optimize StruckLike size estimator * fix check style * add unit test comment --------- Co-authored-by: luting <dylzlt93299@gmail.com> Co-authored-by: wangtao <wangtao3@corp.netease.com>
…pache#1163) * feat: update introduce content * feat: revert * fix: repeat display container info --------- Co-authored-by: zhubeibei <zhubeibei@corp.netease.com>
# Conflicts: # ams/ams-server/src/main/java/com/netease/arctic/ams/server/repair/CallCommandHandler.java # ams/ams-server/src/main/java/com/netease/arctic/ams/server/repair/Context.java # ams/ams-server/src/main/java/com/netease/arctic/ams/server/repair/command/CallCommand.java # ams/ams-server/src/main/java/com/netease/arctic/ams/server/repair/command/OptimizeCall.java # ams/ams-server/src/main/java/com/netease/arctic/ams/server/repair/command/RepairCall.java # ams/ams-server/src/main/java/com/netease/arctic/ams/server/repair/command/RepairCallGenerator.java # ams/ams-server/src/main/java/com/netease/arctic/ams/server/repair/command/ShowCall.java # ams/ams-server/src/main/java/com/netease/arctic/ams/server/repair/command/SimpleRegexCommandParser.java
shidayang
approved these changes
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
(For example: The Arctic Flink dataStream API has already supported this configuration: 'scan.startup.mode', but it is not available with Flink SQL. We should expose this configuration to users when they are using Flink SQL.)
Brief change log
(For example:)
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation