Cannot update or delete a target if it is in a bad state

[quintessence]

If two fields of a target are inadvertently switched:

$ shield show target 67c24213-31b7-495d-a6b5-d2131e5ffc03
UUID:         67c24213-31b7-495d-a6b5-d2131e5ffc03
Name:         sandbox-bosh
Summary:      Sandbox BOSH Database

Plugin:       postgres
Endpoint:     a.b.c.d:pppp
SHIELD Agent: {"pg_user": "vcap","pg_password": "c1oudc0w","pg_host": "localhost","pg_port": "5524","pg_bindir": "/var/vcap/packages/postgres-9.4.2/bin","pg_dump_args": ""}

Then the target cannot be edited or deleted. The shield CLI output will indicate that the edit or deletion is successful, but using show target or ls targets shows the target still present and unedited.

This issue may also apply to stores as well, for a similar reason.

[quintessence]

This may be a use case for shield edit <store | target | schedule | policy> UUID --raw to pass raw JSON using an editor.

[jhunt]

Agree. Can we put in another issue for --raw support?

Are you thinking of keeping the $EDITOR support from bkp, or just supporting reading from stdin?

[quintessence]

I was thinking that using $EDITOR from bkp would be most straightforward, unless you have a better idea handy :)

[jhunt]

Ah, I missed the "using an editor" part.

For scripting / automation (i.e. concourse jobs), I see the use case going like so:

cat | shield create job --raw <<EOF
{
  "the": "json",
  "definition": ["goes", "here"]
}
EOF

Which doesn't require an editor. Might be easier to implement.

[quintessence]

That's a good point - I think that solution might make more sense.

[jhunt]

I cannot repro this issue, but I did just push #43 to help in the diagnostics.

[quintessence]

Issue appears to be resolved with latest commits.