Treat non-200 responses as errors in CLI #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- If there is JSON, try to decode it, but return an error anyway. - If there is no JSON, return the error - In the front-end, display those errors Execute() and Invoke() got merged, because the second return val from Execute() was pointless (bool ok - I found the command!), and once that was removed, the funcs were identical.
quintessence
pushed a commit
that referenced
this pull request
Jan 15, 2016
Treat non-200 responses as errors in CLI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Execute() and Invoke() got merged, because the second return val from
Execute() was pointless (bool ok - I found the command!), and once that
was removed, the funcs were identical.