Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix snapcraft docker container #161

Closed
wants to merge 48 commits into from
Closed

fix snapcraft docker container #161

wants to merge 48 commits into from

Conversation

trxcllnt
Copy link

@trxcllnt trxcllnt commented Jul 1, 2019

Re: #149 (comment)

  • Fixes snapcraft docker container
  • Updates electron-builder to fix snapcraft version check error
  • Adds docker-build-and-package.sh to run containerized local builds

shiftkey and others added 17 commits July 2, 2019 14:39
@shiftkey
refresh README and installation docs for Linux packages
1c59b86
@shiftkey
additional Travis config to simplify CI for this fork
dde719f 
 - linux is the default branch, to simplify PR work
 - release tags need to trigger CI builds
 - test packaging as part of each successful CI build
 - publish a draft GitHub release to the fork when a tag is pushed
@shiftkey
add docker containers for building and packaging Desktop on Linux
5f1c8dc
@shiftkey
improvements to Azure Pipelines to support packaging for Linux
eb08141
@shiftkey
use more specific package name for Linux builds
2281f51
@shiftkey
upgrade electron-builder to latest version
689dd32
@shiftkey
assorted changes to electron-builder config
2e4ccd4
@shiftkey
enable builds for this branch too
f4246f6
@joshirio @shiftkey
Snap: use system theme and xwayland
458d1df
@shiftkey
setup containers to use Node 11 now
705061b
@shiftkey
compute checksums within package step
105458f
@shiftkey
ignore latest-linux.yml when publishing
57e1d38
@shiftkey
adapt packaging script to build snap for classic enclosure
90b1f72
@shiftkey
update section about snap store (shiftkey#135)
a11fb55
@shiftkey
redirect in-app menu for reporting an issue to the fork (shiftkey#141)
03bc90c
@shiftkey
use the app menu bar for Linux instead of the default chrome (shiftke…
f9252b1 
…y#139)
@immackay @shiftkey
Update README for Arch Installs (shiftkey#146)
377c556 
Provided some simple information about gnome-keyring.

Changed the AUR link from `github-desktop` to `github-desktop-bin` to save user hassle.
@shiftkey shiftkey mentioned this pull request Jul 2, 2019
Merged
@shiftkey
Copy link
Owner

shiftkey commented Jul 2, 2019

@trxcllnt thanks for digging into the Snaprcraft docker image setup!

I rebased your work on #162 because I wanted to get the linux branch back and building so I could publish a release, but once I'm back from holidays I'll have time to dig into this further.

shiftkey and others added 22 commits July 2, 2019 17:58
@shiftkey
additional Travis config to simplify CI for this fork
cc79f6f 
 - linux is the default branch, to simplify PR work
 - release tags need to trigger CI builds
 - test packaging as part of each successful CI build
 - publish a draft GitHub release to the fork when a tag is pushed
@shiftkey
add docker containers for building and packaging Desktop on Linux
aa37098
@shiftkey
improvements to Azure Pipelines to support packaging for Linux
645cdb2
@shiftkey
use more specific package name for Linux builds
1ea3798
@shiftkey
upgrade electron-builder to latest version
06d1595
@shiftkey
assorted changes to electron-builder config
88a0a1d
@shiftkey
enable builds for this branch too
885cce2
@joshirio @shiftkey
Snap: use system theme and xwayland
b879728
@shiftkey
setup containers to use Node 11 now
a66cc5c
@shiftkey
compute checksums within package step
9dc41ea
@shiftkey
ignore latest-linux.yml when publishing
dd55f0c
@shiftkey
adapt packaging script to build snap for classic enclosure
82b2c8e
@shiftkey
update section about snap store (shiftkey#135)
dd1c262
@shiftkey
redirect in-app menu for reporting an issue to the fork (shiftkey#141)
e3fff42
@shiftkey
use the app menu bar for Linux instead of the default chrome (shiftke…
275ae9b 
…y#139)
@immackay @shiftkey
Update README for Arch Installs (shiftkey#146)
fee9d32 
Provided some simple information about gnome-keyring.

Changed the AUR link from `github-desktop` to `github-desktop-bin` to save user hassle.
@shiftkey
update toolchain to use Node 12
d10eb2d
@shiftkey
revert this workaround to ensure we build for all platforms
9153893
@shiftkey
workaround for Linux users of the app to use it on very low resolutio…
c6607e9 
…n screens
@shiftkey
update electron-builder to detect newer snapcraft versions
0a0ee40
@shiftkey
update snap dockerfile to include additional tools
dfe35c4
@ziggy42 @shiftkey
Detect snap installation of Visual Studio Code on Linux (shiftkey#156)
17bb901
@shiftkey
Copy link
Owner

shiftkey commented Feb 4, 2020

I'd love to get snap support back and working but it's too broken for me currently.

Please follow along with #202 in the meantime.

@shiftkey shiftkey closed this Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@trxcllnt @shiftkey @joshirio @immackay @ziggy42