Skip to content

Commit

Permalink
Merge branch 'release/sora-ios-sdk-2024.2.0'
Browse files Browse the repository at this point in the history
  • Loading branch information
miosakuma committed Apr 23, 2024
2 parents c12da94 + f0e0770 commit 2a6328d
Show file tree
Hide file tree
Showing 33 changed files with 142 additions and 57 deletions.
11 changes: 6 additions & 5 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,10 @@ on:

jobs:
build:
runs-on: macos-13
runs-on: macos-14
env:
XCODE: /Applications/Xcode_14.3.1.app
XCODE_SDK: iphoneos16.4
XCODE: /Applications/Xcode_15.2.app
XCODE_SDK: iphoneos17.2
steps:
- uses: actions/checkout@v4
- name: Select Xcode Version
Expand All @@ -24,7 +24,7 @@ jobs:
- name: Show CocoaPods Version
run: pod --version
- name: Restore Pods
uses: actions/cache@v3
uses: actions/cache@v4
with:
path: Pods
key: ${{ runner.os }}-pods-${{ hashFiles('**/Podfile.lock') }}
Expand All @@ -50,7 +50,8 @@ jobs:
CODE_SIGNING_REQUIRED=NO \
CODE_SIGNING_ALLOWED=NO \
CODE_SIGN_IDENTITY= \
PROVISIONING_PROFILE=
PROVISIONING_PROFILE= \
ASSETCATALOG_COMPILER_GENERATE_ASSET_SYMBOLS=NO
- name: Check uncommitted unformatted code
run: |
./lint-format.sh
Expand Down
2 changes: 1 addition & 1 deletion .swift-version
Original file line number Diff line number Diff line change
@@ -1 +1 @@
5.5.1
5.8
19 changes: 19 additions & 0 deletions CHANGES.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,25 @@

## develop

## sora-ios-sdk-2024.2.0

- [UPDATE] Github Actions を actions/cache@v4 にあげる
- @miosakuma
- [UPDATE] Github Actions を macos-14 にあげる
- @miosakuma
- [UPDATE] Github Actions を Xcode 15.2, iphoneos17.2 にあげる
- @miosakuma
- [UPDATE] Github Actions のビルドオプションに `ASSETCATALOG_COMPILER_GENERATE_ASSET_SYMBOLS=NO` を追加する
- Xcode 15 で Asset のシンボルである、GeneratedAssetSymbols.swift が生成されるようになったがこのファイルが SwiftFormat エラー対象となる
- CI では Asset のシンボル生成は不要であるため生成しないようオプション指定を行う
- [Xcode 15 リリースノート - Asset Catalogs](https://developer.apple.com/documentation/xcode-release-notes/xcode-15-release-notes#Asset-Catalogs)
- @miosakuma
- [UPDATE] システム条件を変更する
- macOS 14.4.1 以降
- Xcode 15.3
- Swift 5.10
- @miosakuma

## sora-ios-sdk-2024.1.0

- [UPDATE] システム条件を変更する
Expand Down
2 changes: 1 addition & 1 deletion Podfile
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ platform :ios, '13.0'

target 'SoraQuickStart' do
use_frameworks!
pod 'Sora', '2024.1.0'
pod 'Sora', '2024.2.0'
pod 'SwiftLint'
pod 'SwiftFormat/CLI'

Expand Down
10 changes: 7 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,9 @@ Please read https://github.com/shiguredo/oss before use.

- iOS 13 以降
- アーキテクチャ arm64 (シミュレーターの動作は未保証)
- macOS 14.3.1 以降
- Xcode 15.2
- Swift 5.9.2
- macOS 14.4.1 以降
- Xcode 15.3
- Swift 5.10
- CocoaPods 1.15.2 以降
- WebRTC SFU Sora 2023.2.0 以降

Expand All @@ -41,3 +41,7 @@ Xcode と Swift のバージョンによっては、 CocoaPods で取得でき
```

3. ``SoraQuickStart.xcworkspace`` を Xcode で開いてビルドします。

## ライセンス

このリポジトリに含まれるすべてのアプリアイコン画像(すべての PNG 形式ファイル)のライセンスは [CC BY-NC-ND 4.0](https://creativecommons.org/licenses/by-nc-nd/4.0/deed.ja) です。
2 changes: 1 addition & 1 deletion SoraQuickStart/AppDelegate.swift
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import UIKit

@UIApplicationMain
@main
class AppDelegate: UIResponder, UIApplicationDelegate {
func application(_ application: UIApplication, didFinishLaunchingWithOptions launchOptions: [UIApplication.LaunchOptionsKey: Any]?) -> Bool {
// Override point for customization after application launch.
Expand Down
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
143 changes: 99 additions & 44 deletions SoraQuickStart/Assets.xcassets/AppIcon.appiconset/Contents.json
Original file line number Diff line number Diff line change
@@ -1,103 +1,158 @@
{
"images" : [
{
"filename" : "40.png",
"idiom" : "iphone",
"size" : "20x20",
"scale" : "2x"
"scale" : "2x",
"size" : "20x20"
},
{
"filename" : "60.png",
"idiom" : "iphone",
"size" : "20x20",
"scale" : "3x"
"scale" : "3x",
"size" : "20x20"
},
{
"filename" : "29.png",
"idiom" : "iphone",
"size" : "29x29",
"scale" : "2x"
"scale" : "1x",
"size" : "29x29"
},
{
"filename" : "58.png",
"idiom" : "iphone",
"size" : "29x29",
"scale" : "3x"
"scale" : "2x",
"size" : "29x29"
},
{
"filename" : "87.png",
"idiom" : "iphone",
"size" : "40x40",
"scale" : "2x"
"scale" : "3x",
"size" : "29x29"
},
{
"filename" : "80.png",
"idiom" : "iphone",
"size" : "40x40",
"scale" : "3x"
"scale" : "2x",
"size" : "40x40"
},
{
"size" : "60x60",
"filename" : "120.png",
"idiom" : "iphone",
"filename" : "iphone-app@2x.png",
"scale" : "2x"
"scale" : "3x",
"size" : "40x40"
},
{
"size" : "60x60",
"filename" : "57.png",
"idiom" : "iphone",
"filename" : "iphone-app@3x.png",
"scale" : "3x"
"scale" : "1x",
"size" : "57x57"
},
{
"filename" : "114.png",
"idiom" : "iphone",
"scale" : "2x",
"size" : "57x57"
},
{
"filename" : "120.png",
"idiom" : "iphone",
"scale" : "2x",
"size" : "60x60"
},
{
"filename" : "180.png",
"idiom" : "iphone",
"scale" : "3x",
"size" : "60x60"
},
{
"filename" : "20.png",
"idiom" : "ipad",
"scale" : "1x",
"size" : "20x20"
},
{
"filename" : "40.png",
"idiom" : "ipad",
"scale" : "2x",
"size" : "20x20"
},
{
"filename" : "29.png",
"idiom" : "ipad",
"scale" : "1x",
"size" : "29x29"
},
{
"filename" : "58.png",
"idiom" : "ipad",
"scale" : "2x",
"size" : "29x29"
},
{
"filename" : "40.png",
"idiom" : "ipad",
"size" : "20x20",
"scale" : "1x"
"scale" : "1x",
"size" : "40x40"
},
{
"filename" : "80.png",
"idiom" : "ipad",
"size" : "20x20",
"scale" : "2x"
"scale" : "2x",
"size" : "40x40"
},
{
"filename" : "50.png",
"idiom" : "ipad",
"size" : "29x29",
"scale" : "1x"
"scale" : "1x",
"size" : "50x50"
},
{
"filename" : "100.png",
"idiom" : "ipad",
"size" : "29x29",
"scale" : "2x"
"scale" : "2x",
"size" : "50x50"
},
{
"filename" : "72.png",
"idiom" : "ipad",
"size" : "40x40",
"scale" : "1x"
"scale" : "1x",
"size" : "72x72"
},
{
"filename" : "144.png",
"idiom" : "ipad",
"size" : "40x40",
"scale" : "2x"
"scale" : "2x",
"size" : "72x72"
},
{
"size" : "76x76",
"filename" : "76.png",
"idiom" : "ipad",
"filename" : "ipad-app@1x.png",
"scale" : "1x"
"scale" : "1x",
"size" : "76x76"
},
{
"size" : "76x76",
"filename" : "152.png",
"idiom" : "ipad",
"filename" : "ipad-app@2x.png",
"scale" : "2x"
"scale" : "2x",
"size" : "76x76"
},
{
"size" : "83.5x83.5",
"filename" : "167.png",
"idiom" : "ipad",
"filename" : "ipad-pro-app@2x.png",
"scale" : "2x"
"scale" : "2x",
"size" : "83.5x83.5"
},
{
"filename" : "1024.png",
"idiom" : "ios-marketing",
"size" : "1024x1024",
"scale" : "1x"
"scale" : "1x",
"size" : "1024x1024"
}
],
"info" : {
"version" : 1,
"author" : "xcode"
"author" : "xcode",
"version" : 1
}
}
}
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
6 changes: 6 additions & 0 deletions SoraQuickStart/Assets.xcassets/Contents.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"info" : {
"author" : "xcode",
"version" : 1
}
}
4 changes: 2 additions & 2 deletions SoraQuickStart/ViewController.swift
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ class ViewController: UIViewController {
guard let strongSelf = self else {
return
}
if let error = error {
if let error {
NSLog(error.localizedDescription)
DispatchQueue.main.async {
let alertController = UIAlertController(title: "接続に失敗しました",
Expand All @@ -101,7 +101,7 @@ class ViewController: UIViewController {
// 接続試行中の状態を強制的に終了させることができます。
connectionTask = Sora.shared.connect(configuration: config) { mediaChannel, error in
// 接続に失敗するとエラーが渡されます。
if let error = error {
if let error {
NSLog(error.localizedDescription)
DispatchQueue.main.async { [weak self] in
let alertController = UIAlertController(title: "接続に失敗しました",
Expand Down

0 comments on commit 2a6328d

Please sign in to comment.