Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Care Opportunities: Prevention and ASCVD Risk Calculation. Exporting. #182

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

dhes
Copy link

@dhes dhes commented Mar 24, 2021

  1. Care Opportunities > USPSTF > Prevention returns: “US Preventative Services Task Force Recommendations Not Available At This Time”
    Problem: USPSTF API is not accepting POST requests
    Edits: Change to GET request

  2. Care Opportunities > ASCVD Risk returns error
    Problem: The RxNav API has deprecated the NDFRT relaSource in favor of MEDRT
    MEDRT doesn't offer a simple way to select statins. (It does fine with lipid-lowering medicines.)
    Edit: Change to NDFRT for anti-hypertensives.
    Use a hard-coded list for statins in place of RxNav API search.

  3. Export > Export Entire Database hangs
    Problem: the script expects the MySQL server to be localhost
    asuser does not have privileges to create the database nosh_copy
    Edits: Specify env('DB_HOST') in place of 'localhost'
    add -h env('DB_HOST) parameter to mysql and mysqldump commands
    Before running script, manually run in MariaDB-Nosh mysql session: GRANT ALL PRIVILEGES ON . TO 'asuser'@'%';
    Notes: Works on Docker implementation. Not tested on non-Docker setup.

  4. Problem: Deprecated is misspelled ('depreciated')
    Edits: Correct spelling.

  5. Problem: In ascvd_calc() in Controller.php there is $SPB where $SBP was intended, causing incorrect risk calculation.
    Edits: Corrected

@dhes
Copy link
Author

dhes commented Apr 2, 2021

Add fix to Export>Entire Database (SQL Format). Fix mismatched indices in database_export function in CoreController. Fix progress bar so it adds up to 100% when task is completed. Correct area-valuenow to aria-valuenow. Status: Progress bar now reaches 100%, but progressModal still doesn't close.

Dan Heslinga added 3 commits April 11, 2021 15:13
…, and incorporated the forked version by adding lines to composer.json and Dockerfile. 2) Various comments.
@dhes
Copy link
Author

dhes commented Apr 12, 2021

  1. Crash during Export>All Chart. I forked and modified tcpdi-merger, and incorporated it by adding lines to composer.json and Dockerfile.
  2. Changed Postgres driver in database.php to suite the ml database
  3. Fix duplicate key and spelling error in forms.yaml
  4. Various comments

@dhes
Copy link
Author

dhes commented Apr 12, 2021

Sorry please disregard comment 'Changed Postgres driver in database.php to suite the ml database'. I didn't stage that change. Apologies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant