Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dist/onig.wasm not available in 0.11.0 #337

Closed
mcintyre94 opened this issue Aug 11, 2022 · 5 comments
Closed

dist/onig.wasm not available in 0.11.0 #337

mcintyre94 opened this issue Aug 11, 2022 · 5 comments

Comments

@mcintyre94
Copy link
Contributor

mcintyre94 commented Aug 11, 2022

In our app we use shiki.setCDN('https://unpkg.com/shiki/'), and the code that loads dist/onig.wasm is redirecting from https://unpkg.com/shiki/dist/onig.wasm to the new https://unpkg.com/shiki@0.11.0/dist/onig.wasm

But this path doesn't seem to exist in the 0.11.0 release: https://unpkg.com/browse/shiki@0.11.0/dist/

Is it intentional that there's no dist/onig.wasm in the latest version? I can't see any wasm files at all in the latest version. The code seems to still be trying to load dist/onig.wasm on the latest version: https://github.dev/shikijs/shiki/blob/33ae6b97eda78484460ac05b3338bc72a605194a/packages/shiki/src/loader.ts#L52

@orta
Copy link
Contributor

orta commented Aug 11, 2022

Hrm, there's no docs on how to deploy shiki, so it's very possible that I shipped it wrong - will take a look

@Gerrit0
Copy link
Contributor

Gerrit0 commented Aug 11, 2022

It should autodeploy if a PR bumping the version is merged

@orta
Copy link
Contributor

orta commented Aug 11, 2022

(sorry, low on time today, will look tomorrow)

Yeah, I thought that would be it ( https://github.com/shikijs/shiki/runs/7785870097?check_suite_focus=true#step:8:304 ) but it failed for what I think are access token issues

@orta orta closed this as completed in 3176b23 Aug 13, 2022
@orta
Copy link
Contributor

orta commented Aug 13, 2022

Fixed in 0.11.1 - thanks for the report!

@JeroenDerks
Copy link

Thanks for the work and the great library!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants