Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] // ^? unable to take effect #595

Closed
3 of 5 tasks
Closed
3 of 5 tasks

Comments

@kingsword09
Copy link

kingsword09 commented Feb 19, 2024

Validations

Describe the bug

Integrate twoslash according to the official documentation, in vitepress, // ^? There is no expected effect.
Shiki’s official documentation does not have the desired effect.
shiki vitepress
image

devDependencies:

"shiki": "^1.1.5",
"@shikijs/transformers": "^1.1.5",
"@shikijs/twoslash": "^1.1.5",
"vite": "^5.0.11",
"vitepress": "^1.0.0-rc.40",
"@shikijs/vitepress-twoslash": "^1.1.5",

Reproduction

https://github.com/shikijs/shiki/blob/main/docs/packages/vitepress.md?plain=1#L85

Contributes

  • I am willing to submit a PR to fix this issue
  • I am willing to submit a PR with failing tests
@antfu antfu closed this as completed in b667b75 Feb 20, 2024
diegohaz pushed a commit to ariakit/ariakit that referenced this issue Feb 23, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [shiki](https://togithub.com/shikijs/shiki)
([source](https://togithub.com/shikijs/shiki/tree/HEAD/packages/shiki))
| [`1.1.1` ->
`1.1.6`](https://renovatebot.com/diffs/npm/shiki/1.1.1/1.1.6) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/shiki/1.1.6?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/shiki/1.1.6?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/shiki/1.1.1/1.1.6?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/shiki/1.1.1/1.1.6?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>shikijs/shiki (shiki)</summary>

### [`v1.1.6`](https://togithub.com/shikijs/shiki/releases/tag/v1.1.6)

[Compare
Source](https://togithub.com/shikijs/shiki/compare/v1.1.5...v1.1.6)

#####    🚀 Features

- Provide lang sub module for alias  -  by
[@&#8203;antfu](https://togithub.com/antfu) in
[shikijs/shiki#596
[<samp>(b61a6)</samp>](https://togithub.com/shikijs/shiki/commit/b61a689b)
- Include new `Typst` grammar  -  by
[@&#8203;antfu](https://togithub.com/antfu)
[<samp>(9f70e)</samp>](https://togithub.com/shikijs/shiki/commit/9f70eed4)

#####    🐞 Bug Fixes

- **vitepress**: Missing `:shown` prop for query, fix
[#&#8203;595](https://togithub.com/shikijs/shiki/issues/595)  -  by
[@&#8203;antfu](https://togithub.com/antfu) in
[shikijs/shiki#595
[<samp>(b667b)</samp>](https://togithub.com/shikijs/shiki/commit/b667b75a)

#####     [View changes on
GitHub](https://togithub.com/shikijs/shiki/compare/v1.1.5...v1.1.6)

### [`v1.1.5`](https://togithub.com/shikijs/shiki/releases/tag/v1.1.5)

[Compare
Source](https://togithub.com/shikijs/shiki/compare/v1.1.4...v1.1.5)

#####    🐞 Bug Fixes

- **monaco**: Editor colors interop, fix
[#&#8203;594](https://togithub.com/shikijs/shiki/issues/594)  -  by
[@&#8203;antfu](https://togithub.com/antfu) in
[shikijs/shiki#594
[<samp>(78825)</samp>](https://togithub.com/shikijs/shiki/commit/788250d7)

#####     [View changes on
GitHub](https://togithub.com/shikijs/shiki/compare/v1.1.4...v1.1.5)

### [`v1.1.4`](https://togithub.com/shikijs/shiki/releases/tag/v1.1.4)

[Compare
Source](https://togithub.com/shikijs/shiki/compare/v1.1.3...v1.1.4)

#####    🚀 Features

- Add length and time limit to tokenizer  -  by
[@&#8203;ije](https://togithub.com/ije) and
[@&#8203;antfu](https://togithub.com/antfu) in
[shikijs/shiki#588
[<samp>(2803f)</samp>](https://togithub.com/shikijs/shiki/commit/2803f898)

#####    🐞 Bug Fixes

- **monaco**: Normalize hex color for monaco, fix
[#&#8203;594](https://togithub.com/shikijs/shiki/issues/594)  -  by
[@&#8203;antfu](https://togithub.com/antfu) in
[shikijs/shiki#594
[<samp>(ecb36)</samp>](https://togithub.com/shikijs/shiki/commit/ecb36e23)

#####     [View changes on
GitHub](https://togithub.com/shikijs/shiki/compare/v1.1.3...v1.1.4)

### [`v1.1.3`](https://togithub.com/shikijs/shiki/releases/tag/v1.1.3)

[Compare
Source](https://togithub.com/shikijs/shiki/compare/v1.1.2...v1.1.3)

#####    🚀 Features

- New terraform lang, update deps  -  by
[@&#8203;antfu](https://togithub.com/antfu)
[<samp>(52d0a)</samp>](https://togithub.com/shikijs/shiki/commit/52d0a62d)

#####    🐞 Bug Fixes

- **vitepress**: Don't set exit code when throws is set to false  -  by
[@&#8203;antfu](https://togithub.com/antfu)
[<samp>(e2a0a)</samp>](https://togithub.com/shikijs/shiki/commit/e2a0a432)

#####     [View changes on
GitHub](https://togithub.com/shikijs/shiki/compare/v1.1.2...v1.1.3)

### [`v1.1.2`](https://togithub.com/shikijs/shiki/releases/tag/v1.1.2)

[Compare
Source](https://togithub.com/shikijs/shiki/compare/v1.1.1...v1.1.2)

#####    🚀 Features

- New lang Move and new theme Vesper  -  by
[@&#8203;antfu](https://togithub.com/antfu)
[<samp>(8247b)</samp>](https://togithub.com/shikijs/shiki/commit/8247ba72)

#####    🐞 Bug Fixes

- Remove trailing newline added by markdown-it  -  by
[@&#8203;KermanX](https://togithub.com/KermanX) and
[@&#8203;antfu](https://togithub.com/antfu) in
[shikijs/shiki#585
[<samp>(b559c)</samp>](https://togithub.com/shikijs/shiki/commit/b559cde5)
- **twoslash**: Improve error handling  -  by
[@&#8203;antfu](https://togithub.com/antfu)
[<samp>(73fdb)</samp>](https://togithub.com/shikijs/shiki/commit/73fdbd17)

#####     [View changes on
GitHub](https://togithub.com/shikijs/shiki/compare/v1.1.1...v1.1.2)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/ariakit/ariakit).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNTMuMiIsInVwZGF0ZWRJblZlciI6IjM3LjIwMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment