Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twoslash: meta is passed to the popup types codeblock #747

Closed
4 of 5 tasks
fuma-nama opened this issue Aug 18, 2024 · 0 comments
Closed
4 of 5 tasks

Twoslash: meta is passed to the popup types codeblock #747

fuma-nama opened this issue Aug 18, 2024 · 0 comments

Comments

@fuma-nama
Copy link
Contributor

fuma-nama commented Aug 18, 2024

Validations

Describe the bug

See

The meta options from Twoslash transformer is passed to another this.codeToHast to render codeblocks in popups.
However, the meta isn't supposed to be inherited on child codeblocks.

An example is that if we have a title meta like { title: "Test", __raw: "something else" }, this will cause the code blocks in popups also inherit the same title.

image

Reproduction

https://codesandbox.io/p/devbox/amazing-fast-gkzsks

Contributes

  • I am willing to submit a PR to fix this issue
  • I am willing to submit a PR with failing tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants