Remove sync-exec dependency in favor of child_process.spawnSync #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is motivated by security vulnerabilities in sync-exec https://nodesecurity.io/advisories/310.
|
Looks like the build is failing now. Could you fix that? |
|
I did revert mocha to the original version which fixes the previous build failure. (I had updated it because npm audit was yelling at me) Now the build fails because CI is using Node v0.10.48, but child_process.spawnSync was only added in v0.11.12. Do you wish to remain compatible with v0.10.48? |
|
Thank you, I think we're good with dropping support for v0.10. |
|
Any update on this? It's affecting packages downstream, thanks! |
eNzyOfficial
approved these changes
Dec 14, 2018
|
The Travis test failed because somehow it is still using node 0.10.48 Maybe you are using some environment variables in Travis? The tests are passing locally. |
|
@unional nope, I'm not using any env vars there. |
|
I have fixed it on @felipewer fork. Should be coming in soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested fix for issue #2.