Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade gradle version #144

Merged
merged 8 commits into from
May 10, 2023
Merged

Conversation

gamamoe
Copy link
Member

@gamamoe gamamoe commented May 5, 2023

관련 이슈 또는 PR 번호

resolve #143

PR 종류

  • 버그 수정
  • 호환성 변경

PR 설명

JDK 17에서 빌드 실패 수정

@gamamoe gamamoe added the bug label May 5, 2023
@gamamoe gamamoe self-assigned this May 5, 2023
@gamamoe gamamoe marked this pull request as ready for review May 5, 2023 05:08
@gamamoe gamamoe requested review from shin285 and 9bow May 5, 2023 05:08
@gamamoe
Copy link
Member Author

gamamoe commented May 5, 2023

@shin285 @9bow
JDK 17 지원을 위해서 Gradle 및 SpringBoot 버전까지 수정한 꽤 큰 변경입니다
우선 GitHub runner에서의 CI는 JDK [8, 11, 17] 그리고 OS [Ubuntu, Windows, macOS] 모두 통과하는 것은 확인했습니다

다만 큰 변경이다보니, 각자의 local 환경 (가능하면 여러가지 변수 윈도우즈, Mac, 여러 JDK)에서 다른 Gradle task (publish, compile, 스SpringBoot local running) 테스트를 후 큰 문제 없으면 Approve 부탁드립니다

최종 Merge는 제가 할게요

Copy link
Member

@shin285 shin285 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

정상 동작 확인했습니다!

@gamamoe gamamoe merged commit aeb0db6 into shineware:master May 10, 2023
@gamamoe gamamoe deleted the upgrade-gradle-version branch May 10, 2023 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Gradle version
2 participants