Exposed Fill and TabIndex props to Icons #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
I updated icons by removing Thank you for your contribution. |
|
Thank you for clearing things up!
…On Mon, Mar 18, 2024, 7:59 AM Shinichi Okada ***@***.***> wrote:
I updated icons by removing fill and tabindex.
Since all icons are outline, you don't need the fill.
I added withEvents so that tabindex is unnecessary.
Thank you for your contribution.
—
Reply to this email directly, view it on GitHub
<#1 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHBXFP2UDJR3YYJMOCTMM53YY36MHAVCNFSM6AAAAABE2ON4XOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBUGE2DONBWGQ>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Description
Exposed the fill and tabIndex props to icons.
The documentation refers to tabindex but adding the props did nothing. When I looked at the package code, I found that it wasn't defined.
✅ Checks