Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2 GCC 4.9.0 and NAN v2.x syntax issues #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MatthewRalston
Copy link

@MatthewRalston MatthewRalston commented Nov 14, 2016

I encountered some issues installing bgzf on CentOS 6 using Node v4. Eventually I discovered that the issues were related to my C compiler and the library NAN. The addresses issue #2 .

  1. I needed to specify more modern C++ libraries, such as 4.9.0 in my environment.
  2. The * character in package.json for Nan was replaced with major release v2, and the syntax has changed dramatically.
  3. I updated the function declarations/exports to match the Nan v2 syntax.

@MatthewRalston MatthewRalston changed the title Fixing GCC 4.9.0 and NAN v2.x syntax issues Fixes #2 GCC 4.9.0 and NAN v2.x syntax issues Nov 14, 2016
@shinout
Copy link
Owner

shinout commented Nov 14, 2016

Thanks for using this repo. Looks good to me except that shrinkwrap.json is included. Is it really necessary?

@MatthewRalston
Copy link
Author

Necessary? Well, the main reason this became an issue in the first place is because of the '*' in the Nan dependency. Shinkwrapping ensures that this dependency will run as is when downloaded in the future, guaranteed. Id you prefer that this is removed, then I will do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants