gdev: graceful exit even after failed init #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Repeated calls to gdev_major_exit will not cause a kernel panic.
shinpei0208
added a commit
that referenced
this pull request
Jul 9, 2012
gdev: graceful exit even after failed init (committed by kris7topher)
|
Hi Kristóf, This is great! I have merged your commit to the master branch. Thanks,
|
shinpei0208
added a commit
that referenced
this pull request
Nov 7, 2012
gdev: graceful exit even after failed init (committed by kris7topher)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Repeated calls to gdev_major_exit will not cause a kernel panic.
If gdev_major_init fails, it will call gdev_major_exit. At module unload, gdev_major_exit is called again.
This might result in a kernel panic, which makes writing and testing gdev code extremely time-consuming.
In this patch, this issue is fixed by introducing some null checks into gdev_major_exit and related code.
Thus it is safe the call gdev_major_exit several times in a row, effectively making the second and later calls
a no-op.