Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All Artisan arguments not passed through #18

Closed
tymondesigns opened this issue Oct 20, 2017 · 8 comments
Closed

All Artisan arguments not passed through #18

tymondesigns opened this issue Oct 20, 2017 · 8 comments

Comments

@tymondesigns
Copy link

tymondesigns commented Oct 20, 2017

Hi mate.. Great job on the package

When I run something like ./vessel artisan preset none

It seems like the last argument is not being passed through as seen here

image

This obviously works when running php artisan preset none on the host.

And other single argument commands work as expected such as ./vessel artisan horizon

Am I doing something wrong here?

Cheers

EDIT: it's weird that this doesn't work since you use php artisan "$@" in the bash script... confused lol

@fideloper
Copy link
Contributor

fideloper commented Oct 20, 2017 via email

@tymondesigns
Copy link
Author

Yea the command is a native Laravel one

It is kind of weird that it doesn't fit with all the other commands that are separated by a colon (All of those seem to work by the way)

I can't think of another command that has a separate argument

image

@fideloper
Copy link
Contributor

fideloper commented Oct 20, 2017 via email

@tymondesigns
Copy link
Author

tymondesigns commented Oct 20, 2017

I've found the problem line

it's here:
image

As you can see when I shutdown the containers, it works as expected!

image

I'm not skilled enough at bash to fix it though Apparently I am 😄

@tymondesigns
Copy link
Author

Actually PR #19 fixes the issue

@fideloper
Copy link
Contributor

Fixed in d8b9026. I'll make a release soon, gotta just test another commit (unrelated) as well.

@tymondesigns
Copy link
Author

Cool that dogfooding is possible haha

image

@fideloper
Copy link
Contributor

Love it :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants