Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecation Warning #229

Closed
seansellek opened this issue Jan 13, 2018 · 1 comment
Closed

Deprecation Warning #229

seansellek opened this issue Jan 13, 2018 · 1 comment

Comments

@seansellek
Copy link

The dependency ember-diff-attrs causes a deprecation warning when run with 2.18:

DEPRECATION: An addon is trying to access project.nodeModulesPath. This is not a reliable way to discover npm modules. Instead, consider doing: require("resolve").sync(something, { basedir: project.root }). Accessed from: DependencyVersionChecker.NPMDependencyVersionChecker (/Users/ssellek/Impinj/new-imc/threshold-monitor/node_modules/ember-diff-attrs/node_modules/ember-cli-version-checker/src/npm-dependency-version-checker.js:11:32)

They have released a fix, covered here: workmanw/ember-diff-attrs#8, with version 0.2.1.

Bump the required version from 0.2.0 -> 0.2.1 in order to avoid this deprecation.
@seansellek seansellek mentioned this issue Jan 13, 2018
Merged
@RobbieTheWagner
Copy link
Owner

Merged the PR, so closing this. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@seansellek @RobbieTheWagner