Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Unable to import test-helpers in ember 3.0 (i.e. isFlatPickerOpen, setFlatpickrDate etc..) #244

Closed
dbendaou opened this issue Apr 9, 2018 · 4 comments

Comments

@dbendaou
Copy link

dbendaou commented Apr 9, 2018

You've added ember-native-dom-helpers in devDependencies but if you don't have this package in your project it will fail

And start-app.js is no longer required in ember 3 so the helpers should be imported in test-helpers.js

@RobbieTheWagner
Copy link
Owner

Would you be interested in submitting a PR to fix those things up? 😄

@dbendaou dbendaou changed the title Unable to import test-helpers in ember 3.0 (i.e. isFlatPickerOpen, setFlatpickrDate etc..) test: Unable to import test-helpers in ember 3.0 (i.e. isFlatPickerOpen, setFlatpickrDate etc..) Apr 9, 2018
@dbendaou
Copy link
Author

dbendaou commented Apr 9, 2018

Why not I will try to submit one before the end of the week :) 👍

@RobbieTheWagner
Copy link
Owner

@dbendaou I believe I fixed this issue, and it no longer uses ember-native-dom-helpers. Can you confirm?

@dbendaou
Copy link
Author

dbendaou commented Apr 12, 2018

Yep, ember-native-dom-helpers is no longer needed I've just test it after an update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants