Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ember-source v.3.4 => Deprecate component#sendAction #264

Closed
danielspaniel opened this issue Aug 30, 2018 · 4 comments
Closed

ember-source v.3.4 => Deprecate component#sendAction #264

danielspaniel opened this issue Aug 30, 2018 · 4 comments
Assignees
@RobbieTheWagner

Comments

@danielspaniel
Copy link

Hi there. Looks like you are still using sendAction somewhere in the flatpicker component, and ember now deprecates that. Do you have time to fix that? If you need a hand let me know.
@RobbieTheWagner
Copy link
Owner

Hi @danielspaniel we're using it in several spots. We should use closure actions instead. I'd be open to a PR if you would like.

@danielspaniel
Copy link
Author

Actually, I realize I have to fix my own addons Robert, so I will let you get this one for now.

@RobbieTheWagner RobbieTheWagner self-assigned this Aug 30, 2018
@Kilowhisky Kilowhisky mentioned this issue Sep 19, 2018
Merged
@Kilowhisky
Copy link
Contributor

Here's the PR for it.

@RobbieTheWagner
Copy link
Owner

This was closed by #266

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RobbieTheWagner RobbieTheWagner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@danielspaniel @RobbieTheWagner @Kilowhisky