Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ember-flatpickr now observes changes to altFormat attr #256

Merged
merged 2 commits into from
Oct 8, 2018

Conversation

Techn1x
Copy link
Contributor

@Techn1x Techn1x commented Jul 8, 2018

Fixes #255

So the test actually fails because flatpickr itself doesn't currently update altFormat for some reason. I have made them aware of the issue here;
flatpickr/flatpickr#1431

So this PR is just in preparation for when that issue is fixed - it should work once that's done.


Unrelated, a different test about locales was failing too

not ok 16 Chrome 67.0 - Integration | Component | ember flatpickr: locale works correctly
actual: > décembre
expected: >Décembre

@Techn1x Techn1x mentioned this pull request Jul 8, 2018
@RobbieTheWagner RobbieTheWagner merged commit d8a226e into RobbieTheWagner:master Oct 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

altFormat not binded?
2 participants