-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flatpickr as mixin #279
Flatpickr as mixin #279
Conversation
@betocantu93 I think this sounds like a good idea. Please let me know when you have it ready for me to review. |
@rwwagner90 sure, you can check it now, I know yuidoc commets are not there - I'm not quite sure how to place them in the mixin, it always break the build - Basically I moved the |
@rwwagner90 here is a working addon using my fork ember-paper-flatpickr |
This more or less looks good. I am going to merge, then clean some things up later. Thanks for the PR! |
Excellent, thanks @rwwagner90 |
This is a work in progress and to be honest, I'm not familiar with yuidocs and the build was breaking and I didn't had the time to dig into it, but basically this refactor mimics the
ember-pikaday
approach to use a mixin so we can compose components, with this mixin I can for example extend / hookember-paper
'spaper-input
and use all the validations, dom and css from itPlease, let me know what you think