Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_findHost in included for third addons #280

Merged

Conversation

betocantu93
Copy link
Contributor

In order to let other ui libs such as ember-paper use ember-flatpickr via third addons integrations like ember-paper-flatpickr the host app via ember-cli-build.js should be able to define flatpickr options, like the theme or locales, as normal ember-flatpickr do... so this PR makes sure we find the host app, so we can access the app.options.flatpickr options.

It's actually a copy paste from ember-paper include hook.

@RobbieTheWagner
Copy link
Owner

@betocantu93 I assume you tested this and it works for your addon?

@betocantu93
Copy link
Contributor Author

@rwwagner90 yes, I tested it in my addon and it works

@RobbieTheWagner RobbieTheWagner merged commit 0ccc4c5 into RobbieTheWagner:master Dec 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants