Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow flatpickrRef access via an action #286

Merged
merged 1 commit into from
Jan 3, 2019

Conversation

cah-brian-gantzler
Copy link
Contributor

Currently access to the flatpickrRef is only done via two-way binding which is against DDAU. This also prevents the component being used with angle-bracket syntax.

Created an action onFlatpickrRef to replace the two-way binding.

@RobbieTheWagner
Copy link
Owner

Thanks for the PR @cah-briangantzler! My one concern here is the naming. Perhaps setFlatpickrRef instead of onFlatpickrRef?

@cah-brian-gantzler
Copy link
Contributor Author

cah-brian-gantzler commented Jan 3, 2019

Most actions usually are preceded by on, but I can change to set if you wish. setFlatpickrRef though would seem to be you are setting something on the ember-flatpickr component when in fact the action will setting something on the parent. How about getFlatpickrRef or onGetFlatpickrRef?

@RobbieTheWagner
Copy link
Owner

getFlatpickrRef works for me. on implies something is changing and I've typically seen things like onChange onUpdate etc. I want to make it clear it's for getting access to the flatpickr reference, and not something to observe changes for when the flatpickr reference is set.

@cah-brian-gantzler
Copy link
Contributor Author

I have updated this

@RobbieTheWagner RobbieTheWagner merged commit dc1387a into RobbieTheWagner:master Jan 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants