Ember 3.20 #508
Ember 3.20 #508
Conversation
| "ember-cli-node-assets": "^0.2.2", | ||
| "ember-diff-attrs": "^0.2.2", | ||
| "fastboot-transform": "^0.1.3", | ||
| "flatpickr": "^4.6.3" | ||
| "flatpickr": "4.6.3" |
There was a problem hiding this comment.
why did you pin the version? seems unrelated to the Ember update, no?
There was a problem hiding this comment.
Pinned until I have time to debug why latest makes things fail
There was a problem hiding this comment.
I've been using 4.6.5 and it seems to work fine for me 🤔
There was a problem hiding this comment.
4.6.6 was causing failures both here and in Ember Inspector. Flatpickr is notorious for releasing a patch version and changing the entire internal structure of the classes, mousedown vs click etc handlers, but only releasing a patch because the external API did not change. When we write tests against it though, they all start failing and we have to figure out what the new thing is.
There was a problem hiding this comment.
I see, thanks. might be worth mentioning in the changelog though 😉
There was a problem hiding this comment.
Yes, for sure. The hope is to get a full refactor away from mixins in shortly, update flatpickr to latest, and get a new major release out. Apologies for the temporary lack of detail on the change, but stay tuned 😃
No description provided.