Remove Mixin, refactor to glimmer component #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t to a glimmer component. Used Ember-cli-update to update ember-cli to 3.20.0 and ran all the codemods that it had.
added 4 commits
August 12, 2020 11:59
…r/render-modifiers as a prod dependency.
…as glimmer components were only available starting ember-3.13. Updated readme.
LuisAverhoff
force-pushed
the
refactor/ember-flatpickr-glimmer
branch
from
39d3f2f to
6accbc4
Compare
RobbieTheWagner
requested changes
Aug 12, 2020
LuisAverhoff
force-pushed
the
refactor/ember-flatpickr-glimmer
branch
from
c4392a2 to
33647cc
Compare
LuisAverhoff
force-pushed
the
refactor/ember-flatpickr-glimmer
branch
from
33647cc to
0f0640c
Compare
RobbieTheWagner
approved these changes
Aug 12, 2020
|
Thanks so much for putting in the work on this PR! |
RobbieTheWagner
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed mixin and changed the Ember Flatpickr from a classic component to a glimmer component.