Remove getFlatpickrRef and appendDataInput, update flatpickr to 4.6.6
#514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wn events to click events, and removed the date class property as it is not being used anywhere in the class. The actual date object is in the this.args object.
… the _flatpickr property.
… native getter. Inspecting the object returned by flatpickr reveals that the input element is stored as a reference. Removed the appendDataInput property since users of the addon can add a `data-input-*` prop directly to the input thanks to the `...attributes`.
…allback action. Updated tests and usage.md.
RobbieTheWagner
changed the title
getFlatpickrRef in favor of onReady, update flatpickr to 4.6.6
RobbieTheWagner
changed the title
getFlatpickrRef in favor of onReady, update flatpickr to 4.6.6getFlatpickrRef and appendDataInput, update flatpickr to 4.6.6
RobbieTheWagner
approved these changes
Aug 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated
flatpickrto v4.6.6, fix failing tests by changing allmousedownevents toclickevents, and removed thedateclass property as it is not being used anywhere in the class. The actual date object is in thethis.argsobject.