Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compatibility with workspaces #603

Merged
merged 1 commit into from
Dec 18, 2020
Merged

compatibility with workspaces #603

merged 1 commit into from
Dec 18, 2020

Conversation

jakesjews
Copy link
Contributor

Use require.resolve to handle when node_modules might be elsewhere like with yarn workspaces

@RobbieTheWagner
Copy link
Owner

Seems okay to me! @chuckcarpenter does this look how you would expect for workspaces?

chuckcarpenter
chuckcarpenter reviewed Dec 18, 2020
View reviewed changes
Copy link
Contributor

@chuckcarpenter chuckcarpenter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rwwagner90 not an expert, but LGTM from what I know about how that works with path resolution.

@RobbieTheWagner RobbieTheWagner merged commit 45bcb64 into RobbieTheWagner:master Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chuckcarpenter chuckcarpenter chuckcarpenter left review comments

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jakesjews @RobbieTheWagner @chuckcarpenter