Skip to content

Commit

Permalink
Remove spec.builder from the API
Browse files Browse the repository at this point in the history
  • Loading branch information
qu1queee committed May 23, 2021
1 parent c580d14 commit 1928515
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 49 deletions.
19 changes: 0 additions & 19 deletions deploy/crds/shipwright.io_buildruns.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -129,25 +129,6 @@ spec:
buildSpec:
description: BuildSpec is the Build Spec of this BuildRun.
properties:
builder:
description: Builder refers to the image containing the build
tools inside which the source code would be built.
properties:
credentials:
description: Credentials references a Secret that contains
credentials to access the image registry.
properties:
name:
description: 'Name of the referent. More info: https://kubernetes.io/docs/concepts/overview/working-with-objects/names/#names
TODO: Add other useful fields. apiVersion, kind, uid?'
type: string
type: object
image:
description: Image is the reference of the image.
type: string
required:
- image
type: object
dockerfile:
description: Dockerfile is the path to the Dockerfile to be used
for build strategies which bank on the Dockerfile for building
Expand Down
19 changes: 0 additions & 19 deletions deploy/crds/shipwright.io_builds.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -58,25 +58,6 @@ spec:
spec:
description: BuildSpec defines the desired state of Build
properties:
builder:
description: Builder refers to the image containing the build tools
inside which the source code would be built.
properties:
credentials:
description: Credentials references a Secret that contains credentials
to access the image registry.
properties:
name:
description: 'Name of the referent. More info: https://kubernetes.io/docs/concepts/overview/working-with-objects/names/#names
TODO: Add other useful fields. apiVersion, kind, uid?'
type: string
type: object
image:
description: Image is the reference of the image.
type: string
required:
- image
type: object
dockerfile:
description: Dockerfile is the path to the Dockerfile to be used for
build strategies which bank on the Dockerfile for building an image.
Expand Down
6 changes: 0 additions & 6 deletions pkg/apis/build/v1alpha1/build_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -77,12 +77,6 @@ type BuildSpec struct {
// image.
Strategy *Strategy `json:"strategy"`

// Builder refers to the image containing the build tools inside which
// the source code would be built.
//
// +optional
Builder *Image `json:"builder,omitempty"`

// Dockerfile is the path to the Dockerfile to be used for
// build strategies which bank on the Dockerfile for building
// an image.
Expand Down
5 changes: 0 additions & 5 deletions pkg/apis/build/v1alpha1/zz_generated.deepcopy.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 1928515

Please sign in to comment.