-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide user control over pod label #625
Comments
implementation wise there could be some overlap with #50 even if the scenarios / goals are not the same |
I'd like to pick this issue as first-time contribution. I'll come back with some draft code in the next few days |
Thanks @Pinolo, you can also have a look at our good-first-issue project to find issues that we assessed to be a good start. |
EP created: shipwright-io/community#86 |
My colleague @alessiopiazza and me put together a draft implementation. We know it doesn't look pretty, but we didn't feel like going for a refactoring without prior discussion. Waiting for feedback on the EP, too |
Labels in Kubernetes are meant to be identifying attributes for the user, see here. As of today, a user can specify labels on all our objects for example to categorize them and to later search for them using this label.
But, we are not propagating these labels further to the TaskRun or Pod. There, we only set a set of hard-coded labels including the BuildRun, Build and BuildStrategy names. For a user, it might make sense to see his labels also on the TaskRun and Pod objects to filter them based on his own categorization.
The text was updated successfully, but these errors were encountered: