Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to add labels and annotations to build pod #1150

Closed
wants to merge 1 commit into from

Conversation

wanjunlei
Copy link
Contributor

@wanjunlei wanjunlei commented Nov 8, 2022

Signed-off-by: wanjunlei wanjunlei@kubesphere.io

Changes

This pr adds two fields labels and annotations to the Build and BuildRun CRD, the controller will add the labels and annotations to the taskrun, and eventually be added to the build pod.

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

Add support to add labels and annotations to build pod

@openshift-ci openshift-ci bot added the release-note Label for when a PR has specified a release note label Nov 8, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 8, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign heavywombat for approval by writing /assign @heavywombat in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wanjunlei wanjunlei force-pushed the labels branch 3 times, most recently from 5a3dd36 to 7831ade Compare November 9, 2022 08:49
Signed-off-by: wanjunlei <wanjunlei@kubesphere.io>
@binnn6
Copy link

binnn6 commented Nov 11, 2022

Maybe we should just label build and buildrun, and let pod inherit labels from build and buildrun as #625 #1069

@SaschaSchwarze0
Copy link
Member

Thanks for engaging @wanjunlei

In Shipwright, we often distinguish two personas: build strategy authors and build users. Build strategy authors define which steps need to be performed to reach a certain behavior. Pod annotations often cause a behavior, for example kubernetes.io/ingress-bandwidth (network traffic shaping). Build users should not necessarily gain control over such behaviors.

Because of this, we already have the capability to propage annotations from build strategies to taskruns, but not from builds or buildruns. See Propagating annotations from the build strategy to the pod.

Similarly, there is effort in progress related to labels, and here to also include a propagation for Build users.

We invite you to join our community meeting, https://github.com/shipwright-io/community#how-can-i-get-involved.

In general, every API change requires an enhancement proposal, which we call SHIPs.

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 15, 2022
@qu1queee qu1queee closed this Jun 20, 2024
@qu1queee qu1queee added the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. release-note Label for when a PR has specified a release note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants