Ensure volume name does not end with a trailing dash

[SaschaSchwarze0]

Changes

In certain use cases, for example for a bundle source, we need to turn a secret name into a volume name to mount its data in the container. For this we have a translation function. But that had a problem.

Assuming the secret name is abcdefghijklmnopqrstuvwxyz-abcdefghijklmnopqrstuvwxyz-abcd-efgh.

It prefixed shp- -> shp-abcdefghijklmnopqrstuvwxyz-abcdefghijklmnopqrstuvwxyz-abcd-efgh.

It trimmed to at most 63 characters -> shp-abcdefghijklmnopqrstuvwxyz-abcdefghijklmnopqrstuvwxyz-abcd-.

And that was it.

But now the volume name ended with a dash which is not allowed. Adding code to trim trailing dashes.

Submitter Checklist

• Includes tests if functionality changed/was added
• Includes docs if changes are user-facing
• Set a kind label on this PR
• Release notes block has been filled in, or marked NONE

Release Notes

Secret names which had a dash at the 59th characters could not be used for a bundle source because of an error in the translation of secret into volume names

[qu1queee]

ty, good catch

/approve
/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qu1queee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [qu1queee]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment