Deprecate alpha features #1111
Merged
Deprecate alpha features #1111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This deprecates the `spec.sources` field, thereby deprecating the "remote artifact" download feature. Per discussion in the Beta API workshop, this feature will be removed from Shipwright once the beta API reaches stability.
Deprecate the build status subobject. This will be removed in the beta API.
Deprecate the following fields in the `Build` spec object: - `builder` - this is specific to source-to-image. - `dockerfile` - this is specific to Dockerfile-based tools.
Deprecate the generated service account behavior. This feature will eventually be removed from Shipwright.
openshift-ci
bot
added
release-note
|
/assign @SaschaSchwarze0 |
SaschaSchwarze0
approved these changes
Sep 7, 2022
Comment on lines
120
to
+122
| // +optional | ||
| // | ||
| // NOTICE: Multiple sources in a build are deprecated. This feature will be removed in a future release. |
There was a problem hiding this comment.
It seems to work based on what I see being generated. For consistency, I would always have the "annotations" at the end.
Suggested change
| // +optional | |
| // | |
| // NOTICE: Multiple sources in a build are deprecated. This feature will be removed in a future release. | |
| // NOTICE: Multiple sources in a build are deprecated. This feature will be removed in a future release. | |
| // | |
| // +optional |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SaschaSchwarze0 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
SaschaSchwarze0
added
the
kind/api-change
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Deprecate the following features from Shipwright Build:
spec.sourcesinBuild(multiple sources and HTTP artifact downloads)statusinBuild(controller validations for Build objects)spec.dockerfileinBuild(provide path to Dockerfile)spec.builderinBuild(provide builder image for s2i builds)spec.serviceaccount.generateinBuildRun(generated service accounts)/kind cleanup
Submitter Checklist
See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
Release Notes