Add Build clientsets and related dependencies #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add build tags to respective types in preparation for the code generation. Add missing `AddToScheme` required by the code generator.
Add Go source file with unnamed import to introduce the code generator to the project and Go modules. Add script that runs the code generator from the vendor directory to create the generated files.
Based on https://www.openshift.com/blog/kubernetes-deep-dive-code-generation-customresources, this provide us with a native implementation for our CRDs resources. This is required for the integration test, also it will enable any other golang project out there, to have access to a package that can provide them with CRUD events for our Build operator CRDs resources.
Code generator dependencies for building clientsets.
Add additional condition to `file` command to exclude the `zz_generated*` files.
qu1queee
requested review from
HeavyWombat
and removed request for
sbose78 and
SaschaSchwarze0
|
/lgtm |
|
/assign @qu1queee |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: HeavyWombat, qu1queee The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
HeavyWombat
approved these changes
Sep 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #292
Aggregate clientsets for Build operator
Based on https://www.openshift.com/blog/kubernetes-deep-dive-code-generation-customresources,
this provide us with a native implementation for our CRDs resources.
This is required for the integration test, also it will enable any other
golang project out there, to have access to a package that can provide them
with CRUD events for our Build operator CRDs resources.
Did this together with @HeavyWombat , but we decided at the end to not redo the whole commit history with
git-duet