-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase log output readability #837
Conversation
Hi @HeavyWombat, you just requested a review from me. Please be aware that I am on vacation and come back July 26th.
|
ed5476f
to
562db3f
Compare
The current output of the Git step was using the log style of the controller, which is configured to be machine consumable. However, the output should be more aligned with the output that is created by other steps. Tools like Kaniko or Buildpacks produce more human style output. Replace `ctxlog` with `log` and simplify log output to be human friendly. Add new end message that contains all relevant details, including HEAD info.
Check current HEAD to get the current branch name. Co-authored-by: Sascha Schwarze <schwarzs@de.ibm.com>
562db3f
to
74ff2e6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SaschaSchwarze0 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
The current output of the Git step was using the log style of the controller,
which is configured to be machine consumable. However, the output should be
more aligned with the output that is created by other steps. Tools like Kaniko
or Buildpacks produce more human style output. This is also feedback that we
received from users, especially in the case when the source retrieval failed for
some reason, for example TYPO of the branch name or similar.
Replace
ctxlog
withlog
and simplify log output to be human friendly.Add new end message that contains all relevant details, including HEAD info.
For reference:
Submitter Checklist
See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.
Release Notes