-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set user-friendly BuildRun status when Pod gets evicted #858
Set user-friendly BuildRun status when Pod gets evicted #858
Conversation
/assign @SaschaSchwarze0 |
@MayukhSobo some sanity checks are failing in this PR, also can you add pls the proper PR template, e.g. (release notes if needed, etc) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code is fine. Please check the validation failure in https://github.com/shipwright-io/build/pull/858/checks?check_run_id=3447027690. Please add the new PodEvicted reason to the table in https://github.com/shipwright-io/build/blob/main/docs/buildrun.md#understanding-the-state-of-a-buildrun.
/approve thanks! aside from the verify failure (got a double import being flagged by |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gabemontero The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
d936c11
to
81d98df
Compare
81d98df
to
b6a413e
Compare
Opting for a better description. Co-authored-by: Sascha Schwarze <schwarzs@de.ibm.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Changes
When a BuildRun Pod gets evicted, then the status of the BuildRun is:
This is mis-leading because an evicted pod has no logs that one can look at. The PR changes the BuildRun status to:
The message is coming from the Pod's status.
Submitter Checklist
Release Notes