Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change uploading condition in build workflow, etc. #611

Merged
merged 1 commit into from
Feb 27, 2020

Conversation

Hamayama
Copy link
Contributor

タイムアウトでの終了は、failure ではなく cancel 扱いになるらしく、
結局、ログが取れませんでした。。。
( https://github.com/Hamayama/Gauche/actions/runs/45007857 )

このため、if: の条件を always() に変更しました。

また、Windows で gosh.exe が存在しないとなる件ですが、
「msiexec が非同期に実行されるため」という情報があったため、対応しました。
( https://devblogs.microsoft.com/setup/waiting-for-msiexec-exe-to-finish/ )

<テスト結果>
https://github.com/Hamayama/Gauche/actions/runs/46039773

<関連情報>
https://practical-scheme.net/wiliki/wiliki.cgi?Gauche%3ABugs#H-1qgtcx1
https://gist.github.com/Hamayama/3cc0e9c0c5283e7fc422360c6e5bd372

関連プルリクエスト #601 #603 #605 #606 #608

@shirok
Copy link
Owner

shirok commented Feb 27, 2020

ども。

@shirok shirok merged commit a8396b7 into shirok:master Feb 27, 2020
@Hamayama Hamayama deleted the actions7 branch March 2, 2020 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants