Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload and many more is broken #2

Closed
s-vhs opened this issue Dec 26, 2022 · 13 comments
Closed

Upload and many more is broken #2

s-vhs opened this issue Dec 26, 2022 · 13 comments

Comments

@s-vhs
Copy link

s-vhs commented Dec 26, 2022

Hey, this (and the one on your website) is completely broken. Can't upload nor view my own list. Sad to see this :(

@shish
Copy link
Owner

shish commented Dec 26, 2022

I didn't realise it was still actively used, so I haven't been monitoring anything beyond "the front page seems to load" - I will take a look ^^

@s-vhs
Copy link
Author

s-vhs commented Dec 27, 2022

:))

@shish
Copy link
Owner

shish commented Jan 12, 2023

So I started trying to fix one tiny thing, but that required me to fix another thing, which required updating another thing... and I pretty much ended up rewriting the whole thing from the ground up ^^;

From my manual testing, things all seem to be working now - please do let me know if anything is broken :)

@shish shish closed this as completed Jan 12, 2023
@s-vhs
Copy link
Author

s-vhs commented Jan 14, 2023

first thing i found:

  • login not working :^)

@shish
Copy link
Owner

shish commented Jan 14, 2023

Can you be more specific? I'm able to log into an existing account, and create / log into a new one o.o

@shish shish reopened this Jan 14, 2023
@s-vhs
Copy link
Author

s-vhs commented Jan 14, 2023

Whenever I hit the "login"-button, it redirects me to /login and then gives me a 404 error.

@s-vhs
Copy link
Author

s-vhs commented Jan 14, 2023

I tested logging in on Opera, Firefox, Chrome, Chromium and Vivaldi, all latest versions.

@shish
Copy link
Owner

shish commented Jan 14, 2023

Ah, hmm - the new error handling behaviour is to return 404 if it can't find the user with that password, which could probably be clearer since that makes it appear that the login page doesn't exist...

It looks like I forgot to make the login process case-insensitive - so if you registered with an uppercase name and try logging in with lowercase, you would see a 404 in that case

(I will make the login case-insensitive and try to give a more useful error message in a bit ^^)

@s-vhs
Copy link
Author

s-vhs commented Jan 15, 2023

Hey, now it works! Thanks :D

@s-vhs s-vhs closed this as completed Jan 15, 2023
@s-vhs
Copy link
Author

s-vhs commented Jan 15, 2023

image

@s-vhs s-vhs reopened this Jan 15, 2023
@s-vhs
Copy link
Author

s-vhs commented Jan 15, 2023

Oh well nevermind :^)

But aside from that, signin up, logging in, uploading, toggling use and deleting works!

@shish
Copy link
Owner

shish commented Jan 18, 2023

To be clear, the problem there is the avatar table overflowing the page when large avatars are uploaded? That is not related to the rewrite, but worth fixing anyway /o/

@s-vhs
Copy link
Author

s-vhs commented Jan 18, 2023

exactly :)

@shish shish closed this as completed in 6b4fec0 Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants