Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollback PSR installation causing massive workflow failures #3

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Rollback PSR installation causing massive workflow failures #3

merged 1 commit into from
Dec 7, 2023

Conversation

caendesilva
Copy link
Contributor

This reverts commit 83d1155 "Revert 'Add psr for PHP 7.0 and above'" as it breaks installations. This rollback will fix shivammathur/setup-php#798 and shivammathur/setup-php#799

@caendesilva caendesilva changed the title Rollback PSR installation Rollback PSR installation causing massive test failures Dec 6, 2023
@caendesilva caendesilva changed the title Rollback PSR installation causing massive test failures Rollback PSR installation causing massive workflow failures Dec 6, 2023
@kressaty
Copy link

kressaty commented Dec 6, 2023

merge it!

caendesilva added a commit to hydephp/cli that referenced this pull request Dec 6, 2023
caendesilva added a commit to hydephp/cli that referenced this pull request Dec 6, 2023
@tomschlick
Copy link

tagging @shivammathur for visibility

@dereuromark
Copy link

Such changes should only be done in majors IMO. Thanks for the quick revert
It broke probably millions of CI :)

@caendesilva
Copy link
Contributor Author

Such changes should only be done in majors IMO. Thanks for the quick revert It broke probably millions of CI :)

Agreed. I don't think this change was intentional at all, which is why I think it needs to be rolled back ASAP so that it can be properly rereleased in a major update. Hoping it can get merged soon. Considering how much the Setup PHP action is used and the massive impact it has, I really wish more companies would sponsor the maintainer so more resources could be put into making sure things like this doesn't happen. To be clear, I fully appreciate the work Shivam is doing and acknowledge that we as users of free software don't have the rights to make demands, with that said, the system is pretty broken. In an ideal world the companies that rely on tools like these would sponsor the maintainer so they either could work full time, or pay more developers to be on board. Considering the cost I imagine a faulty change like this could have on production systems it seems like a few dollars a month would be quite little for the companies, but it would quickly add up to something that could make a large difference for the maintainer. Rant over!

ghostwriter added a commit to ghostwriter/compliance that referenced this pull request Dec 6, 2023
Until shivammathur/php-ubuntu#3 is merged

Signed-off-by: Nathanael Esayeas <nathanael.esayeas@protonmail.com>
@shivammathur
Copy link
Owner

@caendesilva
Thanks for the PR.

Apologies for this, The change was a bug fix for shivammathur/setup-php#796, but I guess I created a bigger issue.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mass failure after Ubuntu upgrade