Just use ExtUtils::MakeMaker #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the report. It seems that neilb's arguments do not matter too much if one is using Dist-Zilla, but I complied with this request in order to avoid future complaints (see http://www.joelonsoftware.com/articles/customerservice.html ). This should be fixed in File-Remove-1.56.tar.gz. Thanks again. |
|
Thanks! We (the #toolchain gang) are trying to remove Module::Build as a dependency from high-river distributions, and in my 5.23.9 installation, File::Remove was one of the first distributions to be installed that wanted to use Module::Build. So I'm going after them one by one as I find them :) |
jsonn
pushed a commit
to jsonn/pkgsrc
that referenced
this pull request
Aug 16, 2016
Upstream changes:
1.57 2016-04-24 - Shlomi Fish
- Correct the copyright holder and year.
- Add a test for Kwalitee and 'use warnings'.
1.56 2016-03-23 - Shlomi Fish
- Remove the Build.PL so there won't be two build files.
- shlomif/File-Remove#1
- I think it doesn't matter too much with Dist-Zilla, but to avoid
future complaints, I decided to comply with the request.
- Thanks to Karen Etheridge (ETHER) for the report.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Module::Build is no longer in core, and it is not a great idea to use both Module::Build and ExtUtils::MakeMaker (e.g. see http://neilb.org/2015/05/18/two-build-files-considered-harmful.html). Since Dist::Zilla is in use here, it is very easy to just use EUMM.