Small issue with it thinking that the file "4.2BSD-fortunes" is a percentage. #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 7, 2024 17:17
… since it had a \'.\' in it. The way I handled it is too loop through the entire string after the '.' and check for anything that isn't a digit. If so it will know it is not an attempt to use a non-integer percent value. I think a smarter way to handle this is to check if there is a \'%\' at the end of the string
…tead of the older naive approach. This should work fine.... Hopefully
|
Huh it seems like the Cmake files weren't in .gitignore, thats not good. |
|
Hi @257m ! Thanks for the pull-request but I am closing it given the commits in it contain large swaths of cmake files and codes. Feel free to submit a new one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation checks if the first character is a digit and loops through the string to until it reaches a character that isn't. If the next character is a '.' after the digits it assumes the string is a non-integer and spits out an error. The problem with this approach is that just because it saw a '.' after a bunch of digits doesn't mean the user is even trying to use a percentage. In this case I am trying to specify a file. The update I made was that instead of that it goes to the end of the string and checks if the last character is a '%', if so it will it give an error after a '.' but if there isn't a '%', it will assume that it is not a percentage specifying a probability.