Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix cperl strict hashpairs since v5.27.0c #16

Closed
wants to merge 1 commit into from
Closed

fix cperl strict hashpairs since v5.27.0c #16

wants to merge 1 commit into from

Conversation

rurban
Copy link
Contributor

@rurban rurban commented Jan 9, 2018

and libxml v2.9.7.1 tested ok

rurban added a commit to rurban/distroprefs that referenced this pull request Jan 9, 2018
@rurban
XML-LibXML-2.0132-cperl527.patch
78ddcf5 
see shlomif/perl-XML-LibXML#16
@shlomif
Copy link
Owner

shlomif commented Jan 9, 2018

  1. Please keep the change to the Makefile.PL as a seperate commit.

  2. Since this code is unconventional and may seem strange and snowflakey, please extract it into its own function with a clear name and comment.

  3. Investigate why the CIs are failing.

Closing this pull-req for now - awaiting a new one.

@shlomif shlomif closed this Jan 9, 2018
@shlomif shlomif mentioned this pull request Jan 9, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rurban @shlomif