create alpha-vantage data-bundle #155
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaessert
force-pushed
the
atarax_alpha_vantage
branch
3 times, most recently
from
161a568
to
3f0a173
Compare
kaessert
force-pushed
the
atarax_alpha_vantage
branch
4 times, most recently
from
767ceb4
to
745902b
Compare
shlomiku
requested changes
Jan 15, 2021
|
|
||
|
|
||
| if __name__ == '__main__': | ||
| from zipline.data.bundles import register |
There was a problem hiding this comment.
import shouldn't be here. all should be on the top part of the file
There was a problem hiding this comment.
when i put it to the top it fails, don't know why. you're using it like this in the alpaca-bundle, do you remember why?
There was a problem hiding this comment.
I only import modules in the __main__ if it's not used when called from another file. e.g I want to test something but when used in production not called. in our case, we do use the main part to do ingestion in "production" but not only (the module is loaded by __init__ of bundles.
I will take a look at the failure and let you know
kaessert
force-pushed
the
atarax_alpha_vantage
branch
6 times, most recently
from
cadcb4e
to
1539367
Compare
kaessert
force-pushed
the
atarax_alpha_vantage
branch
3 times, most recently
from
bef5dc3
to
596d26f
Compare
kaessert
force-pushed
the
atarax_alpha_vantage
branch
3 times, most recently
from
b284d3a
to
02172f8
Compare
kaessert
force-pushed
the
atarax_alpha_vantage
branch
from
02172f8
to
20b5755
Compare
|
closing this as it's aleady included in the postgres-part |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.