-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
20230415 rayon parallel propagation #216
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shnarazk
changed the title
rayon-propagete as 0.18.0-alpha.2
20230415 rayon propagation
Apr 15, 2023
shnarazk
commented
Apr 15, 2023
…g_watch` updates `start_from`
shnarazk
commented
Apr 16, 2023
src/assign/propagate.rs
Outdated
} | ||
PropagationContext::UpdateWatch(cid, new_watch, k, false_watch_pos) => { | ||
cdb.detach_watch_cache(propagating, &mut source); | ||
cdb.transform_by_updating_watch(cid, false_watch_pos, k, true); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐛 This function reorders the items in the watchlist by calling swap_remove
! 🐛
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So we have to
build a new list during the iteration, then swap to the original.- execute in-place shrinking, then resize after the iteration
use$O(n)$ remove
shnarazk
changed the title
20230415 rayon propagation
20230415 rayon parallel propagation
Apr 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PropagationContext
toClauseTransformer
; then we have to make an entry point toClauseDB
that takes aClauseTransformer
???check_in
debug codesWow!!! It's getting slow!
I found Rayon was not good for this. I need something better.
The first idea
a problem caused by inappropriate evaluation assumption
A new assignment (implication) modifies the checking context. We have to purge the remains and rebuild them.