Maint/issue 14 end production #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ike it as a final solution but do as a step toward one
…truncating the last productions
Prior to this commit there was a requirement that a `;` was used to denote the end of a production. This had the potential to lead to incompatibilities with grammars that weren't doctored for use with this library. After this commit, the `;` remains an optional end of production indicator but is no longer required. End of production is inferred by the end of an expression. End of an expressions is denoted by the following: - eol - `;` - `|` - the start of the next production: `<...> ::=`
CrockAgile
approved these changes
Nov 1, 2017
|
closes #14 |
shnewto
added a commit
that referenced
this pull request
Jul 29, 2020
Maint/issue 14 end production closes #14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple notes on this PR that aren't captured in that last commit message.
;is optional now, I removed it from the Display output, my preference is to default to not showing it.peekmacro lets you "look ahead" but if it finds the pattern it consumes it.