(Incomplete) Implementation of ISO 14977 compliant EBNF parser #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using pest Signed-off-by: Hanif Bin Ariffin <hanif.ariffin.4326@gmail.com>
Using pest because I find nom to not be robust enough to express. I might be wrong and it turns out to be easier to implement with nom. But there are some things that are simply not easily expressable using nom parses. For example, how to express nested group-sequence? For now I am quite tired, this seems to be a lot more complicated that I thought it would be. Turns out this EBNF is quite powerful. I originally intended to use this as a verification tool for DNS names but I think I will just use pest after learning how comprehensive it is. Or just manual parsing. I will leave this to someone more capable. Signed-off-by: Hanif Bin Ariffin <hanif.ariffin.4326@gmail.com> Signed-off-by: Hanif Ariffin <hanif.ariffin.4326@gmail.com>
hbina
force-pushed
the
iso_14977_take_3
branch
from
74a124b
to
0d4eaad
Compare
hbina
changed the title
hbina
changed the title
Signed-off-by: Hanif Bin Ariffin <hanif.ariffin.4326@gmail.com>
|
@hbina thanks for keeping this open for reference for so long! the code base has changed quite a bit since the last activity here so I'm going to close this but I still think ebnf would be a very cool thing to see implemented! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of ISO 14977 compliant EBNF parser
Prior to this PR, this crate only supports BNF parser.
It also didn't use lingos that align with EBNF.
I needed something more "official" and also more powerful since EBNF contains more operators than just
defining-separator-symbol.Admittedly, I am quite sure that BNF can do everything that EBNF can do.
It just requires a bit manual work.
Another functionality that I wanted is the ability to validate a given string and not just generate them.
I will leave that to another PR.
Note
definition_listin something like(5 * {"abcde"} - "xyz") | "fghi";we will get the followingsingle_definition=>(5 * {"abcde"} - "xyz")(with the space included). This should have been detected by the implicit whitespaces...